User talk:Jarry1250/Archive 1
![]() | This is an archive of past discussions. Do not edit the contents of this page. If you wish to start a new discussion or revive an old one, please do so on the current talk page. |
Archive 1 | Archive 2 | Archive 3 | → | Archive 5 |
Percy Shaw Jeffrey
No problem. I was just checking up on my nomination at GAN and saw your nomination. I saw some basic issues that needed fixing and figured I'd help you out instead of having you deal with them when a reviewer looks the article over. If you need help with anything let me know and I'll get back to you as soon as I can. Happy editing! --Nehrams2020 (talk) 20:23, 30 December 2008 (UTC)
Heraldry
Hi Jarry1250, DYK: (Ebay>Euriskodata>23 Heraldry books on one Ebook). If you are further interested in heraldry, this is an excellent research source for early heraldic studies. Regards Stephen2nd (talk) 14:39, 6 January 2009 (UTC)
LivingBot trial
I've just approved a trial for LivingBot. Just in case you aren't familiar with how it works, you need to do the following:
- Have the bot make the specified number of edits (25). If you do a few more or a few less it's ok, but try to hit the target exactly.
- Once that is done, reply at Wikipedia:Bots/Requests for approval/LivingBot including the template {{BotTrialComplete}}. Also include links to the edits, or better a link to your bot's contributions page listing all the edits (the link will be like "http://en.wikipedia.org/w/index.php?title=Special:Contributions&target=LivingBot&offset=YYYYMMDDHHIISS&limit=25" for a timestamp just after the last edit).
- Edit WP:BRFA to move the line {{BRFA|LivingBot||Trial}} to the "Bots that have completed the trial period" section.
Anomie⚔ 14:55, 11 January 2009 (UTC)
65.254.224.34
Hi, I was told you've requested an unblock for 65.254.224.34 (talk · contribs). Is that IP from a personal server you've leased? I doubt it's still an open proxy and an unblock is probably in order. Spellcast (talk) 03:09, 12 January 2009 (UTC)
- Well, it seems to have cleared up by itself, so, you don't need to do anything (for now at least). Thanks anyway. - Jarry1250 (t, c) 08:36, 12 January 2009 (UTC)
(not) Living people
Your bot added category Living people to Frederick Wilhelm Kegel, but he died in 1948. Please take appropriate actions. -- Basilicofresco (msg) 08:55, 13 January 2009 (UTC)
- Moreover it belongs to the category 1948 deaths. I suggest you to add at least a check for the presence of any year of death category. -- Basilicofresco (msg) 09:01, 13 January 2009 (UTC)
- Whilst regrettable, this was not entirely the bot's fault; it merely compounded an existing problem, caused by Thomas.macmillan categorising it as being under [[Category:Year of birth missing (living people)]], as viewable here. Since you've corrected that mistake after you posted above, I hope you understand. Bot judgement is flawed; human judgement is trusted. - Jarry1250 (t, c) 09:42, 13 January 2009 (UTC)
Samuel Harsnett
Citation now added, funnily enough it is the same as the other ones! I never realised how useful the history of my father's old school might be. Now time to add a History section to Chigwell School. --TAS (talk) 17:37, 14 January 2009 (UTC)
Re:Category member lists
Hi, I updated tools:~erwin85/dbq/enwiki_livingbot.txt. The file's encoded in utf-8. --Erwin(85) 20:17, 14 January 2009 (UTC)
Template:Grammar
I had in mind to make a bot run for that . If you can do it with your bot I would be more than happy.
PS If you can please raise your voice about BD in Template talk:Lifetime as well in order we reach a consensus some day.
-- Magioladitis (talk) 12:19, 17 January 2009 (UTC)
CRGS Headmasters
Kudos on the CRGS Headmasters, a lot of work went into these. All the best for Percy Shaw Jeffrey GA review! Hekerui (talk) 18:24, 17 January 2009 (UTC)
LivingBot 5
(Context later added)
Would you mind have a look at task 5's BRFA? It hasn't had a BAG comment yet. I know it's not time-sensitive, but I just hate to be sat here waiting (for a log only run of proposed edits to complete) when I could be doing something. Also, feel free to point out holes in the code! :) - Jarry1250 (t, c) 16:11, 25 January 2009 (UTC)
- I've approved the trial, so now you can set the bot loose on the actual pages :P. Richard0612 16:20, 25 January 2009 (UTC)
- Thanks. - Jarry1250 (t, c) 16:21, 25 January 2009 (UTC)
- Blast - the old IP blocked problem seems to have risen from the dead. I don't know what I can do (it just seems to go away on its own last time around) ... Any ideas? - Jarry1250 (t, c) 16:41, 25 January 2009 (UTC)
- Sorry, I don't remember an 'IP blocked' issue coming up on any previous BRFA so I don't really know what you mean. Could you describe the problem a bit more? (sorry if I've missed something blatantly obvious!) Richard0612 16:46, 25 January 2009 (UTC)
- No, of course you haven't (it came up on BRFA1 before I wiped it)... Right, it's all summarised at [1] - I suppose I'll have to get in touch with an admin. Oh well. - Jarry1250 (t, c) 16:49, 25 January 2009 (UTC)
- Okay, so Rodhullandemu seems to have fixed that (very kindly), so it's onto question 2: change the template before or after the (trial) edits? Either way something's going to break... After would result in the filename and not the image showing up on unchanged articles; before
is less predictablewould result in the image displaying, but with "[[File:" printed above it and the size printed below it. (p.s. sorry for bugging you with all these questions!) - Jarry1250 (t, c) 17:11, 25 January 2009 (UTC)- Firstly, no problem regarding all the questions, this is what BAG is here for in a way! As for when to change the template, I'd change the template first, then do the run (that's what I did in a similar situation). Richard0612 17:26, 25 January 2009 (UTC)
- Trial complete (see BRFA for link). - Jarry1250 (t, c) 17:40, 25 January 2009 (UTC)
- Firstly, no problem regarding all the questions, this is what BAG is here for in a way! As for when to change the template, I'd change the template first, then do the run (that's what I did in a similar situation). Richard0612 17:26, 25 January 2009 (UTC)
- Okay, so Rodhullandemu seems to have fixed that (very kindly), so it's onto question 2: change the template before or after the (trial) edits? Either way something's going to break... After would result in the filename and not the image showing up on unchanged articles; before
- No, of course you haven't (it came up on BRFA1 before I wiped it)... Right, it's all summarised at [1] - I suppose I'll have to get in touch with an admin. Oh well. - Jarry1250 (t, c) 16:49, 25 January 2009 (UTC)
- Sorry, I don't remember an 'IP blocked' issue coming up on any previous BRFA so I don't really know what you mean. Could you describe the problem a bit more? (sorry if I've missed something blatantly obvious!) Richard0612 16:46, 25 January 2009 (UTC)
- Blast - the old IP blocked problem seems to have risen from the dead. I don't know what I can do (it just seems to go away on its own last time around) ... Any ideas? - Jarry1250 (t, c) 16:41, 25 January 2009 (UTC)
LivingBot's IP banned
(Context later added)
You don't have anything to do with this, but would you mind reviewing this block log for me? It's blocking the actions of my bot - I get lost in all the terminology and processes involved. Thanks for any help you can provide. - Jarry1250 (t, c) 16:52, 25 January 2009 (UTC)
- I'll give you IP Block exemption for the bot; leave it with me. --Rodhullandemu 16:57, 25 January 2009 (UTC)
- Thanks! - Jarry1250 (t, c) 17:09, 25 January 2009 (UTC)
Television Film Bot
i am in your debt, sir. cheers! --emerson7 19:47, 25 January 2009 (UTC)
(Context later added)
Regarding Sarah, Plain and Tall (film), can I have your source for those parameters' being deprecated? I'm trying to improve the template, but I didn't know they were (though deprecating them is probably a good idea, don't get me wrong). - Jarry1250 (t, c) 17:00, 26 January 2009 (UTC)
- Check {{Infobox film}}. It reads: "Parameters "website", "imdb_id" "and amg_id" are now deprecated following extensive discussion. Links to these websites can be added to the "External links" section of an article by using the following templates: {{official}}, {{imdb title}},{{amg movie}}". There is a special section for this as well explaining the reasons. I was thinking to ask for a bot do the job. -- Magioladitis (talk) 17:27, 26 January 2009 (UTC)
- I'll duplicate the deprecation across to {{Infobox Television film}}, as you suggest. (Though it might have been a bit premature to call them deprecated on a different template that didn't call them deprecated!) - Jarry1250 (t, c) 17:30, 26 January 2009 (UTC)
- That was my mistake I just realised. My intend was not to touch Infobox Television film but only Infobox film. I don't know how I got confused. But, still, I think we have to follow the same procedure. I think the discussion is general and completely fits in both cases. -- Magioladitis (talk) 17:32, 26 January 2009 (UTC)
- Definitely - I quite agree. I've opened up a discussion to deprecate on {{Infobox Television film}}'s talk. If you could post some appropriate links to the old discussion there, that would be really helpful. - Jarry1250 (t, c) 17:35, 26 January 2009 (UTC)
- That was my mistake I just realised. My intend was not to touch Infobox Television film but only Infobox film. I don't know how I got confused. But, still, I think we have to follow the same procedure. I think the discussion is general and completely fits in both cases. -- Magioladitis (talk) 17:32, 26 January 2009 (UTC)
- I'll duplicate the deprecation across to {{Infobox Television film}}, as you suggest. (Though it might have been a bit premature to call them deprecated on a different template that didn't call them deprecated!) - Jarry1250 (t, c) 17:30, 26 January 2009 (UTC)
Re:Categorycount
(Context later added)
Yes, it's me again :) I'm currently proposing a bot that relies on category counting, and I could with a bit of advice about the best way of doing so. I could, I think, use an intermediary tool (such as your own categorycount), which would be simple and reliable, but might be unnecessary. The api itself seems quite good, but I don't think it includes subcategories (which I would need). Any thoughts? Once again, it would be best if you could reply on my en wikipedia page. Thanks! Jarry1250 12:08, 31 January 2009 (UTC)
- Hi, as far as I know there's no bot that currently includes subcategories. It would be nice to have one though. To do so you'd have to recursively count the number of pages in a category, its subcategories, their subcategories etc. In the end you'll have to limit the number of levels you include. A tool of mine does exactly that. My own bot however doesn't. You could of course use the api and simply query it for each subcategory, but I'm not sure if that's a good idea. I guess it would be best to do this on the toolserver. If you plan on doing similar stuff I suggest applying for an account at m:Toolserver/New accounts. --Erwin(85) 09:55, 1 February 2009 (UTC)
- Yes, that might be a good idea, particularly as I can't find a good way to get a quick count of the number of transclusions of a template... unless you know of a good way? 92.18.220.214 10:00, 1 February 2009 (UTC)
- Can't you use the api for that? (Though I again suggest using the toolserver.) --Erwin(85) 10:21, 1 February 2009 (UTC)
- Yes, that might be a good idea, particularly as I can't find a good way to get a quick count of the number of transclusions of a template... unless you know of a good way? 92.18.220.214 10:00, 1 February 2009 (UTC)
Headline
(Context later added)
I had nothing better to do, so I just went and changed it myself. Feel free to revert if that's not what you wanted! - Jarry1250 (t, c) 09:49, 1 February 2009 (UTC)
- Many thanks! I've tried to copy the HTML code from the "View source" option, but for some unknown reason it didn't work. Admiral Norton (talk) 10:35, 1 February 2009 (UTC)
Query
Why are you including non-featured articles as 'milestones', while excluding featured pictures and featured sounds? DurovaCharge! 23:52, 1 February 2009 (UTC)
- Your suggestion has duly been added to the list of suggestions. - Jarry1250 (t, c) 10:39, 2 February 2009 (UTC)
- Thank you. :) DurovaCharge! 01:28, 3 February 2009 (UTC)
Your Bot
Wikipedia:WikiProject_Seamounts wants to join this list, but can you explain the requisetes required a bit better? Resident Mario (talk) 01:55, 2 February 2009 (UTC)
- I've had a stab. Any specific concerns? - Jarry1250 (t, c) 10:56, 2 February 2009 (UTC)
re: Milestone Announcements
Thank you for offering this great service to WikiProjects! To the best of my knowledge no, this stuff should be pretty much okay. Probably article count in general by total articles in the project would be more debatable, that's why I did not include that in these initial listings, but rather just the GA/FA/FL quality listings. Cirt (talk) 13:53, 2 February 2009 (UTC)
- Yes, I'd be willing to help. Cirt (talk) 13:58, 2 February 2009 (UTC)
- Thanks so much for adding those - will the bot pick up the pattern after the last number, and keep doing notices every 10 or however many the pattern is? Cirt (talk) 15:53, 2 February 2009 (UTC)
Ah okay. In the future, you may want to automate that last part a bit more. :) Cirt (talk) 16:15, 2 February 2009 (UTC)
- Thanks for offering this service however there won't be a need for a GA/FA/Fl article for a long time sadly. MegX (talk) 06:37, 3 February 2009 (UTC)
Settlements in the Achaea prefecture
Any joy with Wikipedia:Bots/Requests for approval/LivingBot 4? Andy Mabbett (User:Pigsonthewing); Andy's talk; Andy's edits 00:18, 4 February 2009 (UTC)
- I'd sort of forgotten about it. In short, I did the trial edits, but then promptly ran out of tables needing updating (or so the bot thought). If you give me another list (either of ones I missed or different prefectures, whatever), I'll see what I can do. - Jarry1250 (t, c) 07:56, 4 February 2009 (UTC)
- Thanks. There's a bunch at Category:Communities of Greece. Happy hunting! Andy Mabbett (User:Pigsonthewing); Andy's talk; Andy's edits 13:17, 4 February 2009 (UTC)
(Context later added) Okay, so this might sound like a weird favour to ask, but bear with me! Would you mind having a look at Talk:Percy Shaw Jeffrey/GA1? I've tried to reply to some of the concerns raised, but I've basically buggered the lists up. Is there a proper way to format replies? Any improvement you could render to the review would be great, as I do intend to work through most (if not all) the points made. - Jarry1250 (t, c) 19:31, 6 February 2009 (UTC)
- I think I fixed it for you. Cheers, Cirt (talk) 19:36, 6 February 2009 (UTC)
- I don't think "quick" quite covers that. Light speed perhaps? Many thanks, anyhow. - Jarry1250 (t, c) 19:37, 6 February 2009 (UTC)
Re: Milestone Announcements
Re: your message concerning the addition of WikiProject Horror to the bot
If it is not too much trouble, please activate the bot now. If our numbers change drastically, then I won't worry about it terribly. Thank you kindly for offering this great service. hornoir (talk) 14:28, 7 February 2009 (UTC)
Minor value in API
I noticed your questions in #wikipedia-bag, though I was AFK for most of the day. To answer your questions I'm pretty sure you can call a function from a constructor, but you will need to use the $this-> psudovariable just like anything else if the function is in the same class, or if its in a different class you'll need to use the scope resolution operator (::) to call the function. As far as the minor and bot flag, afaik all the variables on the API need both a variable name and value. So you will need to do &bot=1 or something, the value can be whatever, but I'm fairly sure it needs a value. I have changed your subpage to reflect that. As far as the empty tokens, I know a few months back Cobi was having a problem with mediawiki passing empty tokens, though I believe that is fixed, usually that results from not being logged in, which is caused by the session ID cookie not being sent along with the HTTP request. Note that curl sessions are independent of one another, so one curl session will not use the cookies of another, at least afaik. Curl usually takes care of content mime types by itself, at least from my experience, which is one of the nice things about using it. If I missed anything feel free to ping me. —Nn123645 (talk) 03:25, 10 February 2009 (UTC)
Code review of User:LivingBot/Wikibot.php5
Since you stated "Any eyes over the code appreciated" on IRC earlier, I decided to give your code a once-over.
- General
- Consider the possibility of using PHP's CLI, for the many cases where there is no need for the bot to have a web interface.
- Consider the case where the API returns an error (be it an HTTP error or an API error). For example, in
get_cats_of_page
it looks like you can't tell the difference between "page has no cats" and any sort of error. - Consider handling a maxlag error by sleeping a short time and automatically retrying.
- category
- Due to recent changes in the API, the way you pass back the cmcontinue value is broken (the API can now return fewer items than requested if it decides the response would be too big). It's unlikely to happen here, but it would be good to handle it anyway.
- put_page
- Consider including the
md5
parameter in the edit request, it has saved my bot making broken edits a few times. In particular, if you're having UTF8 encoding issues it can save you.
Hope this helps! Anomie? 04:09, 9 February 2009 (UTC)
- I see a few things yet, besides what's still unstruck:
- create_page will probably fail on an API error.
- You're still not going to be correctly handling edit conflicts. Sure, it will always be possible to get around it, but as it is right now it's impossible to not get around it. You need two functions: one to get the old page text + edit tokens, and one to take the edit tokens + the new page text and perform the edit.
- Anomie? 23:44, 10 February 2009 (UTC)
- I see a few things yet, besides what's still unstruck: